Skip to content

Remove extra spaces in comments#312

Merged
nineinchnick merged 1 commit intotrinodb:mainfrom
hongbo-miao:patch-1
May 18, 2025
Merged

Remove extra spaces in comments#312
nineinchnick merged 1 commit intotrinodb:mainfrom
hongbo-miao:patch-1

Conversation

@hongbo-miao
Copy link
Contributor

@hongbo-miao hongbo-miao commented Mar 12, 2025

A small fix, however, took me a while to figure out those spaces should not be there 🥲

@cla-bot
Copy link

cla-bot bot commented Mar 12, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@nineinchnick
Copy link
Member

@sdaberdaku PTAL

@sdaberdaku
Copy link
Member

@nineinchnick the proposed correction is right.
You can see how the indentation should be in test-values.yaml.
@hongbo-miao sorry for this mistake!

@nineinchnick nineinchnick added the documentation Improvements or additions to documentation label Mar 25, 2025
@nineinchnick
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2025
@cla-bot
Copy link

cla-bot bot commented Apr 6, 2025

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick
Copy link
Member

@hongbo-miao can you update the Chart's README to match the changes in values.yaml? See the CI failures.

@nineinchnick
Copy link
Member

@hongbo-miao ping

@nineinchnick nineinchnick changed the title docs(trino): remove extra spaces Remove extra spaces in comments May 18, 2025
@nineinchnick nineinchnick merged commit ba46d73 into trinodb:main May 18, 2025
10 checks passed
@hongbo-miao hongbo-miao deleted the patch-1 branch May 18, 2025 10:11
@hongbo-miao
Copy link
Contributor Author

Thank you @nineinchnick for help update, I missed the comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

3 participants